Skip to content

Conversation

lorenzleutgeb
Copy link
Member

@lorenzleutgeb lorenzleutgeb commented May 18, 2024

I saw #10732 by @drupol and merged by @Ericson2314 and would like to propose the following improvements:

  1. Move the thesis from identifiers to references. Justification: The identifiers key is intended to list identifiers for versions or rather close derivations/packages of the software itself. Eelco's PhD thesis, while its connection to Nix is very obvious, in the CFF model still is a reference because it is not Nix itself. You'll see that definitions.identifier is limited to type being one of "doi", "url", "swh", and "other" (focused on software and datasets) while definitions.reference has keys doi, isbn, url, collection-doi, pmcid that are suited to identify written works and helpful further keys like thesis-type.
  2. Instead of referring to the thesis via the URL that points at GitHub, use the handle provided by Utrecht University. Justification: University libraries usually aim to preserve theses for an indefinite time and are very conscious about preservation. I would have provided the GitHub URL in addition, but it seems that CFF only supports one URL per reference.
  3. Copy metadata such as keywords from Utrecht University.

Note that CFF also supports credit redirection. That is, one can specify a definitions.reference object (like the thesis is with the changes in this PR), under the preferred-citation key. In the case at hand, it would signal "please cite the thesis directly when you want to reference Nix". I opted to not do this, since if I were a long time contributor on the Nix team, I would probably object, as the thesis is only in Eelco's name, but I wanted to mention it here in case the Nix team wants to consider it.

@lorenzleutgeb lorenzleutgeb requested a review from edolstra as a code owner May 18, 2024 18:14
@drupol
Copy link
Contributor

drupol commented May 18, 2024

Thanks, @lorenzleutgeb, for the clarification and the improvements, I agree with everything, and I've learned something new.

@Ericson2314
Copy link
Member

Great changes and especially explanation, thanks so much!

@Ericson2314 Ericson2314 merged commit c2d4c38 into NixOS:master May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants