Skip to content

[Feature] - Verify file hashes before allowing collection upload when using replicate option #17368

@IDCs

Description

@IDCs

Currently Vortex will allow users to upload collections which contain modified file content using the "replicate" install option. This will cause installation errors on the user's end as the hashes used when replicating the modified content will never match the hashes of the original content.

To note:

  • Vortex does not maintain a hash dictionary for the extracted files and therefore this cannot be done synchronously using the current collection diagnostics or with the current state data.
  • There are currently no asynchronous health checks in place which can assist us in ascertaining mod content changes.
  • We are currently not checking if a mod's archive is still available on a curator's machine prior to allowing them to upload a collection (this is relevant as we cannot check for the original files without the archive)

What needs to be done:

  • We need to fix the fallback mechanism for the replicate option as the entire mod will fail to extract any files when encountering a mod with modified content. (it's supposed to extract the mod regularly without applying any structure changes)
  • We need to block collection/revision updates for mods that use the replicate installation option and are missing their original installation archives.
  • We need to simulate regular installation of those mods so that we can extract the hashes of the original files.
  • We need to compare hashes of the simulated installations against the actual data that the collection is meant to export.

Estimated work time + testing: ~5-8 hours

Metadata

Metadata

Assignees

No one assigned

    Labels

    spike 🔎An investigation task

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions