Taiko pacaya support #8331
Merged
Taiko pacaya support #8331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -100,6 +100,7 @@ public class ChainParameters | |||
| public long? Eip1559BaseFeeMinValueTransition { get; set; } | |||
|
|
|||
| public long? OntakeTransition { get; set; } | |||
| public long? PacayaTransition { get; set; } | |||
There was a problem hiding this comment.
Why not Taiko specific parameters?
There was a problem hiding this comment.
so i went ahead and did a refactor for pushing those parameters out of the general spec files. the same can be applied to any gnosis or optimism specific parameters instead of the current approach. CC, @deffrian
flcl42
approved these changes
Mar 10, 2025
# Conflicts: # src/Nethermind/Nethermind.Runner.Test/EthereumRunnerTests.cs # src/Nethermind/Nethermind.Runner/Ethereum/Api/ApiBuilder.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8208
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
will test in devents once built
Documentation
Requires documentation update
Requires explanation in Release Notes
Nethermind is ready for the upcoming Taiko Pacaya hardfork