Skip to content

Init OP deployer account before setting the code #8193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 12, 2025
Merged

Init OP deployer account before setting the code #8193

merged 3 commits into from
Feb 12, 2025

Conversation

flcl42
Copy link
Contributor

@flcl42 flcl42 commented Feb 11, 2025 •
edited
Loading

Fixes #8152 (most likely)

Changes

  • Init account if empty before setting the code of it

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@flcl42 flcl42 marked this pull request as ready for review February 11, 2025 15:11
@emlautarom1
Copy link
Contributor

Let me run a base-archive node with this change to be sure that it's fixed and then we can merge.

@emlautarom1 emlautarom1 merged commit ad629e2 into master Feb 12, 2025
79 checks passed
@emlautarom1 emlautarom1 deleted the fx-canyon-deployer branch February 12, 2025 14:18
emlautarom1 added a commit that referenced this pull request Feb 12, 2025
@emlautarom1
Revert "Init OP deployer account before setting the code (#8193)"
ed1e6fc 
This reverts commit ad629e2.
@emlautarom1 emlautarom1 restored the fx-canyon-deployer branch February 12, 2025 14:18
kamilchodola pushed a commit that referenced this pull request Feb 12, 2025
@flcl42 @kamilchodola
Init OP deployer account before setting the code (#8193)
ac1800b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

@deffrian deffrian Awaiting requested review from deffrian

@emlautarom1 emlautarom1 Awaiting requested review from emlautarom1

Assignees
No one assigned
Labels
bug fix + reliability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

System.InvalidOperationException - account is null (base mainnet archive)
4 participants
@flcl42 @emlautarom1 @LukaszRozmej @benaadams