Skip to content

Conversation

benaadams
Copy link
Member

Changes

  • We output far too much data in JsonRpc error lines, reduce to a single line
  • Currently causing issue for ethPandaOps as logging is the predominate performance hog for them
  • No one really uses the additional detail; and it is a very serious issue we output other Error logs

Open question on whether we want to log the error at all by default as do keep its metric

Types of changes

What types of changes does your code introduce?

  • Optimization
  • Other: Logging

Testing

Requires testing

  • No

benaadams and others added 2 commits April 9, 2025 14:45
Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com>
@benaadams benaadams merged commit 0655cd0 into master Apr 9, 2025
80 checks passed
@benaadams benaadams deleted the json-rpc-log-spam branch April 9, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants