Add metrics for engine_getBlobsV1 full and partial responses
#8495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benaadams
approved these changes
Apr 9, 2025
flcl42
approved these changes
Apr 9, 2025
|
After Fusaka, we can remove |
Mostly meant other metrics 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
NumberOfGetBlobsSuccessesandNumberOfGetBlobsFailuresA successful response to
engine_getBlobsV1may include some (or even all)nullvalues, indicating that the requested blobs are not available. We already track metrics for the number of blobs requested and the number of blobs sent, and based on that, we estimate the return rate on mainnet to be around 85%. For now, partial responses (some blobs returned, somenulls) are useful for the CL.However, after Fusaka's PeerDAS, partial responses will no longer be useful - CL will require either all requested blobs or none. This PR introduces new metrics to track fully successful responses (where all requested blobs are returned) versus successful but incomplete responses (where some blobs are missing). These metrics will help us estimate the rate of fully successful responses, which are critical for PeerDAS.
These metrics are already included in the PeerDAS branch, but we also want to start collecting data from mainnet.
Types of changes
What types of changes does your code introduce?
Testing
Requires testing