Skip to content

Fix FCU result in simulated block production scenarios #8494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 9, 2025
Merged

Fix FCU result in simulated block production scenarios #8494

merged 2 commits into from
Apr 9, 2025

Conversation

marcindsobczak
Copy link
Contributor

Changes

  • fix ForkchoiceUpdatedV1Result in simulated block production scenarios
    Currently, during simulated block production (when payload attributes are added by us), we return a payloadId even though it wasn't requested by CL. This PR corrects that behavior by returning null in such cases, ensuring the simulation remains internal to Nethermind and is not exposed to the CL.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

LukaszRozmej
LukaszRozmej approved these changes Apr 9, 2025
View reviewed changes
Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small improvement

@marcindsobczak @LukaszRozmej
Apply suggestions from code review
988cbb8 
Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com>
@marcindsobczak marcindsobczak merged commit 56fd892 into master Apr 9, 2025
80 checks passed
@marcindsobczak marcindsobczak deleted the fix/fcu_response branch April 9, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benaadams benaadams benaadams approved these changes

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

@kamilchodola kamilchodola kamilchodola approved these changes

@MarekM25 MarekM25 Awaiting requested review from MarekM25

Assignees
No one assigned
Labels
bug fix + reliability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcindsobczak @benaadams @LukaszRozmej @kamilchodola