Skip to content

Include version number in default extra data #8492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 8, 2025
Merged

Include version number in default extra data #8492

merged 2 commits into from
Apr 8, 2025

Conversation

benaadams
Copy link
Member

Changes

  • Include version number in default extra data, meaning it is easier to determine if any issues are fixed issues or different
  • Convert -unsable to a so as not to use up too much space
JSON RPC     : http://127.0.0.1:8545 ; http://localhost:8551
Genesis hash : 0xd4e56740f876aef8c010b86a40d5f56745a118d0906a34e69aec8c0db1cb8fa3
Gaslimit     : 36,000,000
ExtraData    : Nethermind v1.32.0a

Types of changes

What types of changes does your code introduce?

  • New feature (a non-breaking change that adds functionality)

Testing

Requires testing

  • No - will throw exception if wrong on startup and outputs value in startup banner

Copilot
Copilot AI reviewed Apr 8, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

smartprogrammer93
smartprogrammer93 approved these changes Apr 8, 2025
View reviewed changes
rubo
rubo requested changes Apr 8, 2025
View reviewed changes
@rubo rubo requested a review from Copilot April 8, 2025 20:16
Copilot
Copilot AI reviewed Apr 8, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

@benaadams benaadams requested a review from rubo April 8, 2025 20:22
@benaadams benaadams merged commit 0fda0e1 into master Apr 8, 2025
80 checks passed
@benaadams benaadams deleted the extradata branch April 8, 2025 20:25
This was referenced Apr 10, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@rubo rubo rubo approved these changes

@smartprogrammer93 smartprogrammer93 smartprogrammer93 approved these changes

@cbermudez97 cbermudez97 cbermudez97 approved these changes

@MarekM25 MarekM25 Awaiting requested review from MarekM25

@LukaszRozmej LukaszRozmej Awaiting requested review from LukaszRozmej

Assignees
No one assigned
Labels
bug fix + reliability new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benaadams @rubo @smartprogrammer93 @cbermudez97