Cap block build size in bytes #8486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarekM25
reviewed
Apr 8, 2025
| @@ -58,5 +58,7 @@ public byte[] GetExtraDataBytes() | |||
| public string GasToken { get => GasTokenTicker; set => GasTokenTicker = value; } | |||
|
|
|||
| public static string GasTokenTicker { get; set; } = "ETH"; | |||
|
|
|||
| public long BlockProductionMaxTxKilobytes { get; set; } = 9728; | |||
There was a problem hiding this comment.
are you sure it is correct value? how much CL can have on worst-case?
There was a problem hiding this comment.
Docs say 127kB in worse case; but not sure they are outdated so increased to 512kB (as also EL payload framing)
1024*10-512 = 9728
...ethermind/Nethermind.Consensus/Processing/BlockProcessor.BlockProductionTransactionPicker.cs
Outdated
Show resolved
Hide resolved
LukaszRozmej
reviewed
Apr 8, 2025
...ethermind/Nethermind.Consensus/Processing/BlockProcessor.BlockProductionTransactionPicker.cs
Outdated
Show resolved
Hide resolved
928238a to
d7bdd88
Compare
LukaszRozmej
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
10MB is the max L1 CL uncompress block gossip size and also includes the block headers etc https://github.com/ethereum/consensus-specs/blob/dev/specs/phase0/p2p-interface.md#max_message_size
So we shouldn't build passed this size
Types of changes
What types of changes does your code introduce?
Testing
Requires testing