Perf/More accurate request limit. #8474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benaadams
approved these changes
Apr 6, 2025
LukaszRozmej
reviewed
Apr 7, 2025
Comment on lines
+73
to
+79
| public IEnumerator<BlockBody?> GetEnumerator() | ||
| { | ||
| foreach (var blockBody in _rawBodies) | ||
| { | ||
| yield return blockBody; | ||
| } | ||
| } |
There was a problem hiding this comment.
Why not just
Suggested change
| public IEnumerator<BlockBody?> GetEnumerator() | |
| { | |
| foreach (var blockBody in _rawBodies) | |
| { | |
| yield return blockBody; | |
| } | |
| } | |
| public IEnumerator<BlockBody?> GetEnumerator() => _rawBodies.GetEnumerator(); |
| /// on the allocation strategy and context. May not be accurate as different peer may get allocated. | ||
| /// </summary> | ||
| Task<int?> EstimateRequestLimit( | ||
| RequestType bodies, |
There was a problem hiding this comment.
Suggested change
| RequestType bodies, | |
| RequestType requestType, |
| Task<int?> EstimateRequestLimit( | ||
| RequestType bodies, | ||
| IPeerAllocationStrategy peerAllocationStrategy, | ||
| AllocationContexts blocks, |
asdacap
added a commit
that referenced
this pull request
Apr 15, 2025
asdacap
added a commit
that referenced
this pull request
Apr 30, 2025
* Parallel forward sync * Singleton for the block downloader * Some test * Add test for parallel download * Whitespace * Map pruner * Whitespace * Fix build * Move request sizer to node stats * Expose request size * For bodies * Simplify * Fast headers * Receipt sync feed * Also check for response count * DLS and fix test * Fix wrong signature * Use tx count to estimate buffer size * Nicer dsl * Hard timeout * Fix overlow error * Fix overlow error * More tuning * Address comment from #8474 * Fix build * Fix test * Remove unnecessary code * Trying to reduce change * Minor change * Make blocks request disposable * Fix some test * Fix test * Slight cleanup * Minor cleanup * Whitespace * Fix test * Address copilot * Fix test * Update src/Nethermind/Nethermind.Synchronization/Blocks/BlockDownloader.cs Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com> * Update src/Nethermind/Nethermind.Synchronization/Blocks/BlockDownloader.cs Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com> * Update src/Nethermind/Nethermind.Synchronization/Blocks/BlockDownloader.cs Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com> * Update src/Nethermind/Nethermind.Synchronization/Blocks/BlockDownloader.cs Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com> * Update src/Nethermind/Nethermind.Synchronization/Blocks/BlockDownloader.cs Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com> * Update src/Nethermind/Nethermind.Synchronization/Blocks/BlockDownloader.cs Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com> * Update src/Nethermind/Nethermind.Synchronization/Blocks/BlockDownloader.cs Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com> * Update src/Nethermind/Nethermind.Synchronization/Blocks/BlocksSyncPeerSelectionStrategy.cs Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com> * Address comment * Dont change tests * Introduce allocate delay to prevent spinning --------- Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing