Skip to content

Fix benchmark missing any writes #8468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2025
Merged

Fix benchmark missing any writes #8468

merged 1 commit into from
Apr 4, 2025

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented Apr 3, 2025

  • Fix some of the patricia benchmark is broken as it is missing writes.
  • Add another benchmark LargeInsertAndCommit for large insert and commit.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Looks like this.

| Method                          | Mean         | Error       | StdDev       | Median       | Gen0       | Gen1       | Gen2      | Allocated    |
|-------------------------------- |-------------:|------------:|-------------:|-------------:|-----------:|-----------:|----------:|-------------:|
| Scenarios                       |     161.7 us |     1.76 us |      1.65 us |     161.6 us |     7.3242 |          - |         - |    121.52 KB |
| InsertAndHash                   |   1,706.5 us |    33.79 us |     42.73 us |   1,702.7 us |   210.9375 |   130.8594 |         - |   3449.28 KB |
| InsertAndCommit                 |   5,036.1 us |    80.92 us |     67.57 us |   5,029.6 us |   328.1250 |   320.3125 |         - |   5454.28 KB |
| InsertAndCommitRepeatedlyTimes  | 388,886.8 us | 7,682.01 us | 16,203.97 us | 389,999.8 us | 12000.0000 | 11000.0000 | 1000.0000 | 184166.86 KB |
| LargeInsertAndCommit            | 101,387.5 us | 1,978.90 us |  2,502.68 us | 102,109.8 us |  4200.0000 |  3200.0000 |  600.0000 |  61764.97 KB |
| ReadWithFullTree                |     455.2 us |     7.35 us |      6.52 us |     457.7 us |    23.4375 |          - |         - |    386.82 KB |
| ReadWithUncommittedFullTree     |     511.0 us |     2.81 us |      2.35 us |     509.8 us |    23.4375 |          - |         - |    384.01 KB |
| ReadWithMemoryTrieStore         |     432.3 us |     8.64 us |     16.65 us |     424.8 us |    23.4375 |          - |         - |    384.53 KB |
| ReadWithMemoryTrieStoreReadOnly |   2,008.3 us |    38.71 us |     32.33 us |   2,015.8 us |   134.7656 |    82.0313 |         - |   2211.12 KB |
| ReadAndDeserialize              |   1,736.8 us |    34.47 us |     86.47 us |   1,726.7 us |   134.7656 |    82.0313 |         - |   2211.67 KB |

@asdacap asdacap merged commit 285d28d into master Apr 4, 2025
81 checks passed
@asdacap asdacap deleted the fix/partricia-benchmark branch April 4, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asdacap @LukaszRozmej