Skip to content

Fix hive test. #8414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 25, 2025
Merged

Fix hive test. #8414

merged 3 commits into from
Mar 25, 2025

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented Mar 25, 2025 •
edited
Loading

  • Fix failed hive test due to double ISpecProvider initialization.
  • ISpecProvider and other dependencied for INethermindApi now passed in constructor.
  • Created a unit tests to prevent same case.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

  • Hive now runs.

@asdacap asdacap merged commit cfe2326 into master Mar 25, 2025
80 checks passed
@asdacap asdacap deleted the refactor/remove-setter-from-api branch March 25, 2025 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benaadams benaadams benaadams approved these changes

Assignees
No one assigned
Labels
bug fix + reliability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asdacap @benaadams