Feature/Configurable dirty node shard count #8410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaszRozmej
approved these changes
Mar 24, 2025
Comment on lines
+86
to
+89
| if (_shardBit is <= 0 or > 30) | ||
| { | ||
| throw new InvalidOperationException($"Shard bit count must be between 0 and 30."); | ||
| } |
There was a problem hiding this comment.
Move this validation directly to config class?
| : BinaryPrimitives.ReadUInt32BigEndian(hash.Bytes[..4]); | ||
|
|
||
| // Using some early bits so that nodes of similar prefix would get put in the same shard. | ||
| uint shardIdx = baseSize >> (32 - _shardBit); |
There was a problem hiding this comment.
32 - _shardBit could be saved in a field.
benaadams
reviewed
Mar 24, 2025
benaadams
approved these changes
Mar 24, 2025
Co-authored-by: Ben {chmark} Adams <thundercat@illyriad.co.uk>
Scooletz
reviewed
Mar 25, 2025
| @@ -79,4 +79,7 @@ The max number of parallel tasks that can be used by full pruning. | |||
|
|
|||
| [ConfigItem(Description = "The number of past states before the state gets pruned. Used to determine how old of a state to keep from the head.", DefaultValue = "64")] | |||
| int PruningBoundary { get; set; } | |||
|
|
|||
| [ConfigItem(Description = "Dirty node shard count", DefaultValue = "8")] | |||
| int DirtyNodeShardBit { get; set; } | |||
There was a problem hiding this comment.
Should it default to something based on CPU count maybe?
There was a problem hiding this comment.
Maybe, one day. But for now I can't find any difference unless it is set too low where pruning can't parallelize.
benaadams
approved these changes
Mar 25, 2025
Co-authored-by: Ben {chmark} Adams <thundercat@illyriad.co.uk>
Co-authored-by: Ben {chmark} Adams <thundercat@illyriad.co.uk>
benaadams
reviewed
Mar 25, 2025
benaadams
approved these changes
Mar 25, 2025
|
Looks like failure is persistent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing