-
Notifications
You must be signed in to change notification settings - Fork 549
Pack blobs optimally by aggregate fees #8400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Nethermind/Nethermind.Merge.Plugin/BlockProduction/PayloadPreparationService.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Consensus/Producers/TxPoolTxSource.cs
Outdated
Show resolved
Hide resolved
smartprogrammer93
approved these changes
Mar 21, 2025
Scooletz
suggested changes
Mar 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minors
src/Nethermind/Nethermind.Consensus/Producers/TxPoolTxSource.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Consensus/Producers/TxPoolTxSource.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Consensus/Producers/TxPoolTxSource.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Evm/TransactionProcessing/TransactionProcessor.cs
Show resolved
Hide resolved
src/Nethermind/Nethermind.Merge.Plugin/BlockProduction/PayloadPreparationService.cs
Show resolved
Hide resolved
src/Nethermind/Nethermind.Blockchain.Test/TransactionSelectorTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Szymon Kulec <scooletz@gmail.com>
…rmind into blob-packing
LukaszRozmej
approved these changes
Mar 21, 2025
Scooletz
approved these changes
Mar 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better tests now with a stable random, a few cases and a non-trivial distribution of blob fees.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8399
Changes
Examples from mainnet
6 blobs -> 5 blobs -> 4 blobs; with premium fees to block producer going up x8.8 times
Switch to higher paying blobs
Switch to better paying blobs even if count drops (limited space to include blobs)
Better paying 3 blobs selected over 6 blobs; which causes count to drop to 3 (as max is 6, so the 6 blob tx can't be included as would take to 9)
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?