Fix bug in deployer reload logic #2533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes a bug in the deployer reload logic by converting hardcoded module reload behavior into a configurable property. The change allows extension-specific implementations (like maestro) to override which modules get reloaded during deployer initialization.
Key changes:
- Convert hardcoded
to_reloadlist to a property method that can be overridden - Move module list definition from
__init__method to a dedicated property with documentation
Comment on lines
+104
to
+105
| This is used to ensure that the CLI is in a clean state before | ||
| deploying the flow. |
There was a problem hiding this comment.
The docstring should clarify that this property is intended to be overridden by subclasses for extension-specific module reloading, as mentioned in the PR description.
Suggested change
| This is used to ensure that the CLI is in a clean state before | |
| deploying the flow. | |
| This property is intended to be overridden by subclasses for extension-specific | |
| module reloading. Subclasses should override this to specify which modules | |
| need to be reloaded to ensure the CLI is in a clean state before deploying the flow. |
Copilot uses AI. Check for mistakes.
mt-ob
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
to_reloada property that can be overwritten by other implementations likemaestroetc. This is because, sometimes we need to reload extension specific modules.