core: improve handling of large spikes for rolling-sum #1753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update rolling-sum and rolling-mean to better handle cases where there is a large value. Before a really large value compared to others would skew the sum and it would never fully recover since the sum is maintained incrementally. Now it will check if there is a big difference in the exponent and recompute from the buffer to recover.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update rolling-sum and rolling-mean to better handle cases where there is a large value. Before a really large value compared to others would skew the sum and it would never fully recover since the sum is maintained incrementally. Now it will check if there is a big difference in the exponent and recompute from the buffer to recover.