core: fix pagination and lazily compute OR #1754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update RoaringTagIndex implementation to fix pagination of findItems for range and pattern clauses. Before the offset was being ignored for these query clauses. In common usage it often wouldn't be noticed because AND with an equal clause would result in the offset gettng applied via the conjunction. Also updates range queries and patterns to use a lazy OR operation on the bitmap. In some of our benchmarks this improves the throughput by about 30%.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update RoaringTagIndex implementation to fix pagination of findItems for range and pattern clauses. Before the offset was being ignored for these query clauses. In common usage it often wouldn't be noticed because AND with an equal clause would result in the offset gettng applied via the conjunction.
Also updates range queries and patterns to use a lazy OR operation on the bitmap. In some of our benchmarks this improves the throughput by about 30%.