Skip to content

refactor: refactor call expression #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 8, 2022
Merged

refactor: refactor call expression #77

merged 3 commits into from
Nov 8, 2022

Conversation

kiner-tang
Copy link
Collaborator

这个 PR 做了什么? (简要描述所做更改)

  • 使用可选链方式优化函数调用实现，精简代码

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) fix #{issue id}
  • 新功能(Feature) resolve #{issue id}
  • 代码重构(Refactor)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 类型描述更新(TypeScript definition update)
  • 其他，请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 未涉及平台修改
  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台（QuickApp）
  • Web 平台（H5）
  • 移动端（React-Native）

@kiner-tang kiner-tang requested a review from CaedmonW November 8, 2022 02:15
@kiner-tang kiner-tang self-assigned this Nov 8, 2022
@changeset-bot
Copy link

changeset-bot bot commented Nov 8, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: c505a88

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
ossaui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@auto-assign auto-assign bot requested a review from onlychild November 8, 2022 02:15
@vercel
Copy link

vercel bot commented Nov 8, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ossa-demo ✅ Ready (Inspect) Visit Preview Nov 8, 2022 at 2:52AM (UTC)
1 Ignored Deployment
Name Status Preview Updated
ossa-doc ⬜️ Ignored (Inspect) Nov 8, 2022 at 2:52AM (UTC)

@CaedmonW
Copy link
Collaborator

CaedmonW commented Nov 8, 2022

👍

这些地方感觉可以一块改下

OSSA/packages/ossa/src/components/common/pickerPopup/index.tsx

Lines 30 to 40 in 15e76bf

const onClose = () => {
props.onClose && props.onClose();
};
const onCancel = (e: ITouchEvent) => {
props.onCancel && props.onCancel(e);
onClose();
};
const onConfirm = (e: ITouchEvent) => {
props.onConfirm && props.onConfirm(e);

OSSA/packages/ossa/src/components/common/pickerGroup/index.tsx

Lines 106 to 110 in 15e76bf

if (this.props.onUpdateHeight)
this.props.onUpdateHeight(newPos, columnId);
if (this.props.onTouchMove) {
this.props.onTouchMove(e);
}

@kiner-tang
Copy link
Collaborator Author

👍

这些地方感觉可以一块改下

OSSA/packages/ossa/src/components/common/pickerPopup/index.tsx

Lines 30 to 40 in 15e76bf

const onClose = () => {
props.onClose && props.onClose();
};
const onCancel = (e: ITouchEvent) => {
props.onCancel && props.onCancel(e);
onClose();
};
const onConfirm = (e: ITouchEvent) => {
props.onConfirm && props.onConfirm(e);

OSSA/packages/ossa/src/components/common/pickerGroup/index.tsx

Lines 106 to 110 in 15e76bf

if (this.props.onUpdateHeight)
this.props.onUpdateHeight(newPos, columnId);
if (this.props.onTouchMove) {
this.props.onTouchMove(e);
}

恩恩，common看漏了，我改一下

CaedmonW
CaedmonW approved these changes Nov 8, 2022
View reviewed changes
Copy link
Collaborator

@CaedmonW CaedmonW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kiner-tang kiner-tang merged commit db77cc0 into NeteaseYanxuan:main Nov 8, 2022
This was referenced Nov 8, 2022
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaedmonW CaedmonW CaedmonW approved these changes

@onlychild onlychild Awaiting requested review from onlychild

Assignees

@kiner-tang kiner-tang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kiner-tang @CaedmonW