Skip to content

Conversation

kiner-tang
Copy link
Collaborator

@kiner-tang kiner-tang commented Nov 4, 2022

这个 PR 做了什么? (简要描述所做更改)

目前input组件是否显示字符计数器属性名为countDown,容易让用户理解为倒计时,增加理解成本和误解的几率,参考其他各大前端组件库的命名规范,建议改为showCount
为了防止broken change, 先将countDown属性标记为过期属性,暂不删除,同时增加新属性showCount,让用户可以平稳过度,在下一个大版本再删除countDown属性。

  • feat(input): 是否显示字符计数器属性名使用 showCount 属性替代

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) fix #{issue id}
  • 新功能(Feature) resolve #{issue id}
  • 代码重构(Refactor)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 类型描述更新(TypeScript definition update)
  • 其他,请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 未涉及平台修改
  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)

@auto-assign auto-assign bot requested a review from onlychild November 4, 2022 13:52
@changeset-bot
Copy link

changeset-bot bot commented Nov 4, 2022

🦋 Changeset detected

Latest commit: 21c205e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
ossaui Patch
ossa-demo Patch
ossa-doc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Nov 4, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ossa-demo ✅ Ready (Inspect) Visit Preview Nov 6, 2022 at 8:04AM (UTC)
ossa-doc ✅ Ready (Inspect) Visit Preview Nov 6, 2022 at 8:04AM (UTC)

Copy link
Collaborator

@CaedmonW CaedmonW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm


之前的命名确实有歧义

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants