Skip to content

Corrections in Default Dependent Components Versions #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 12, 2025
Merged

Corrections in Default Dependent Components Versions #719

merged 3 commits into from
Mar 12, 2025

Conversation

pranavcracker
Copy link
Collaborator

@pranavcracker pranavcracker commented Feb 17, 2025 •
edited
Loading

Description

  • Corrections in the Default Dependent Components Versions table in Supported Versions for kubernetes version v1.30.3, v1.31.1 and added new table for v1.32.0

Fixes # (issue)

Solution

  • Updated the relevant documentation

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • There is no breaking changes, or migration patch is provided
  • Integration CI passed
  • Unit tests. If Yes list of new/changed tests with brief description
  • There is no merge conflicts

@pranavcracker pranavcracker added the documentation Improvements or additions to documentation label Feb 17, 2025
@pranavcracker pranavcracker self-assigned this Feb 17, 2025
@pranavcracker pranavcracker marked this pull request as ready for review February 17, 2025 06:46
@pranavcracker pranavcracker changed the title corrections in installation.md Corrections in Default Dependent Components Versions Feb 17, 2025
@andrewluckyguy andrewluckyguy self-requested a review March 10, 2025 11:58
@andrewluckyguy
Copy link
Collaborator

There are obsolete v3.28.1 calico versions for v1.29.7 kubernetes:

KubeMarine/documentation/Installation.md

Line 6066 in 3b26394

| | calicoctl | v3.28.1 | v3.28.1 | v3.28.1 | v3.28.1 | v3.28.1 | v3.28.1 | v3.28.1 | SHA1: 80f164a8248b8fa501f35f12cbcac0b059e665e2 Required only if calico is installed. |

KubeMarine/documentation/Installation.md

Line 6078 in 3b26394

| | calico/typha | v3.28.1 | v3.28.1 | v3.28.1 | v3.28.1 | v3.28.1 | v3.28.1 | v3.28.1 | Required only if Typha is enabled in Calico config. |

according to the information in https://github.com/Netcracker/KubeMarine/blob/main/kubemarine/resources/configurations/compatibility/kubernetes_versions.yaml

@pranavcracker
Copy link
Collaborator Author

There are obsolete v3.28.1 calico versions for v1.29.7 kubernetes:

KubeMarine/documentation/Installation.md

Line 6066 in 3b26394

| | calicoctl | v3.28.1 | v3.28.1 | v3.28.1 | v3.28.1 | v3.28.1 | v3.28.1 | v3.28.1 | SHA1: 80f164a8248b8fa501f35f12cbcac0b059e665e2 Required only if calico is installed. |

KubeMarine/documentation/Installation.md

Line 6078 in 3b26394

| | calico/typha | v3.28.1 | v3.28.1 | v3.28.1 | v3.28.1 | v3.28.1 | v3.28.1 | v3.28.1 | Required only if Typha is enabled in Calico config. |

according to the information in https://github.com/Netcracker/KubeMarine/blob/main/kubemarine/resources/configurations/compatibility/kubernetes_versions.yaml

This is corrected.

theboringstuff
theboringstuff approved these changes Mar 11, 2025
View reviewed changes
Copy link
Collaborator

@theboringstuff theboringstuff left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks error-prone to maintain/check so many tables by hand. Maybe we should consider automating it. We already have thirdparties sync script, we could just enhance it to also generate these tables (they could be in a separate file)

@pranavcracker pranavcracker merged commit 7a28f96 into main Mar 12, 2025
41 checks passed
pranavcracker added a commit that referenced this pull request Mar 12, 2025
@pranavcracker
Corrections in Default Dependent Components Versions (#719)
6a5a1c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theboringstuff theboringstuff theboringstuff approved these changes

@andrewluckyguy andrewluckyguy andrewluckyguy approved these changes

@OleksandrIaresko OleksandrIaresko Awaiting requested review from OleksandrIaresko

@nikhil1697 nikhil1697 Awaiting requested review from nikhil1697

@DmitriiRabenok DmitriiRabenok Awaiting requested review from DmitriiRabenok

Assignees

@pranavcracker pranavcracker

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pranavcracker @andrewluckyguy @theboringstuff