Skip to content

Fix reboot task #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 2, 2025
Merged

Fix reboot task #753

merged 2 commits into from
Jul 2, 2025

Conversation

alexarefev
Copy link
Collaborator

@alexarefev alexarefev commented Jun 20, 2025 •
edited
Loading

Description

  • The node could be in SchedulingDisabled status after reboot task if graceful_reboot: True in procedure.yaml

Fixes #654

Solution

  • Rework uncordon part of the reboot_group method

Test Cases

TestCase 1

Test Configuration:

  • Hardware: 2CPU/4GB
  • OS: Ubuntu 22.04
  • Inventory: AllInOne

Steps:

  1. Run kubemarine reboot with graceful_reboot: True in procedure.yaml

Results:

Before After
Node status: NotReady,SchedulingDisabled Node status: Ready

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • There is no breaking changes, or migration patch is provided
  • Integration CI passed
  • There is no merge conflicts

@alexarefev alexarefev added the bug Something isn't working label Jun 20, 2025
@alexarefev alexarefev marked this pull request as ready for review June 20, 2025 09:33
@DmitriiRabenok DmitriiRabenok merged commit 4a80395 into main Jul 2, 2025
35 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nikhil1697 nikhil1697 nikhil1697 approved these changes

@pranavcracker pranavcracker pranavcracker approved these changes

@theboringstuff theboringstuff Awaiting requested review from theboringstuff

Assignees

@DmitriiRabenok DmitriiRabenok

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reboot does kubectl uncordon tolerating to its failure thus leaving the node unschedulable
4 participants
@alexarefev @nikhil1697 @pranavcracker @DmitriiRabenok