per-node kubelet upgrade #746
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During upgrade, if new kubelet version is installed on all nodes and then kubelet service is immediately restarted on all nodes, upgrade will fail, because a lot of pods in the cluster will become non-functional due to inconsistent kubelet/kubernetes version.
Overall, this is risky to upgrade kubelet globally on all nodes at the beginning of the upgrade, because upgrade may fail and cluster will be left in a fragile state with inconsistent kubelet.
Solution
As the least invasive fix, we could upgrade kubelet per-node, right after node draining:
install_all_thirdparties
task:Test Cases
TestCase 1
Steps:
v1.30.10
v1.31.6
with only following tasks (first in upgrade tasks sequence):v1.30.10
(make sure this version still used incluster.yaml
) tov1.31.6
as usual, with all tasks includedResults:
Checklist