Skip to content

Conversation

tutuxxx
Copy link
Member

@tutuxxx tutuxxx commented Apr 30, 2025

这个 PR 做了什么? (简要描述所做更改)

修复独立分包common样式未被引入页面问题

这个 PR 是什么类型? (至少选择一个)

  • [ ✅ ] 错误修复(Bugfix) issue: fix #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • [ ✅ ] 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)
  • 鸿蒙(harmony)

Summary by CodeRabbit

  • 新功能
    • 独立分包下的所有样式文件现会自动引入分包内的 common 样式文件,无需手动添加 @import

Copy link

coderabbitai bot commented Apr 30, 2025

"""

Walkthrough

本次变更在 TaroMiniPlugin 类的 injectCommonStyles 方法中新增了处理独立分包公共样式的逻辑。对于每个独立分包,若存在 common 样式文件,则会在该分包下除 common 以外的所有 CSS 资源前添加 @import 引用该公共样式文件。该更改仅影响独立分包的样式处理,不影响主包或其它公共 chunk 的样式逻辑。

Changes

文件路径 变更摘要
packages/taro-webpack5-runner/src/plugins/MiniPlugin.ts injectCommonStyles 方法中增加独立分包公共样式自动引入逻辑,仅影响独立分包下的样式资源。

Suggested reviewers

  • tutuxxx

Poem

🐰
独立分包添新装,
公共样式一起上。
轻轻一行 import 语,
代码整洁又漂亮。
小兔欢跳来祝贺,
样式共享无烦恼!
🌿✨
"""


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 513e314 and d0fb56e.

📒 Files selected for processing (1)
  • packages/taro-webpack5-runner/src/plugins/MiniPlugin.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/taro-webpack5-runner/src/plugins/MiniPlugin.ts
⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: Build Rust Binding / stable - aarch64-apple-darwin
  • GitHub Check: Build Rust Binding / stable - x86_64-pc-windows-msvc
  • GitHub Check: Build Rust Binding / stable - x86_64-apple-darwin
  • GitHub Check: Build Rust Binding / stable - aarch64-apple-darwin
  • GitHub Check: Build Rust Binding / stable - x86_64-apple-darwin
  • GitHub Check: Build Rust Binding / stable - x86_64-pc-windows-msvc
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@coderabbitai coderabbitai bot requested a review from Single-Dancer April 30, 2025 08:32
@Single-Dancer Single-Dancer added this to the 4.0.13 milestone Apr 30, 2025
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.37%. Comparing base (c2e321a) to head (d0fb56e).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #17621   +/-   ##
=======================================
  Coverage   58.37%   58.37%           
=======================================
  Files         469      469           
  Lines       27230    27230           
  Branches     5975     5949   -26     
=======================================
  Hits        15895    15895           
- Misses       9804     9842   +38     
+ Partials     1531     1493   -38     
Flag Coverage Δ
taro-cli 72.37% <ø> (ø)
taro-runtime 59.87% <ø> (ø)
taro-web 52.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 14 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This was referenced May 3, 2025
@Single-Dancer Single-Dancer force-pushed the fix/independent-commoncss branch from 513e314 to d0fb56e Compare May 6, 2025 07:01
@Single-Dancer Single-Dancer merged commit 1afdb99 into main May 6, 2025
39 checks passed
@Single-Dancer Single-Dancer deleted the fix/independent-commoncss branch May 6, 2025 07:49
This was referenced May 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants