fix: 修复jd下CustomWrapper内的组件className失效问题 #17511

zhengyanan1 · 2025-04-11T02:14:15Z

这个 PR 做了什么? (简要描述所做更改)
jd下CustomWrapper内的组件className, 添加不带wrapper-- 的原样式名

这个 PR 是什么类型? (至少选择一个)

错误修复(Bugfix) issue: fix #
新功能(Feature)
代码重构(Refactor)
TypeScript 类型定义修改(Typings)
文档修改(Docs)
代码风格更新(Code style update)
其他，请描述(Other, please describe):

这个 PR 涉及以下平台:

Summary by CodeRabbit

新功能
- 引入了按平台定制的配置选项，可在特定环境（例如“jd”平台）下自动启用额外全局样式支持，进一步提升了组件配置的灵活性，同时确保现有功能保持不变。

coderabbitai · 2025-04-11T02:14:22Z

Walkthrough

此次更改在 createRecursiveComponentConfig 函数中引入了一个新的变量 extraOptions，用于存储平台特定的配置。当环境变量 TARO_ENV 的值为 'jd' 时，会向 extraOptions 添加属性 addGlobalClass 并设为 true。最终，extraOptions 被合并到返回的 options 对象中，保持了原有逻辑的同时增加了定制化配置的支持。

Changes

文件路径	变更描述
packages/taro-runtime/src/dsl/common.ts	在 `createRecursiveComponentConfig` 中添加 `extraOptions` 变量，并在 `TARO_ENV==='jd'` 时附加 `addGlobalClass: true`，再将其合并到 `options` 对象中

Sequence Diagram(s)

sequenceDiagram
    participant Func as createRecursiveComponentConfig
    participant Env as 环境变量 (TARO_ENV)
    participant Options as 返回的 options 对象

    Func->>Env: 检查 TARO_ENV 的值
    alt TARO_ENV 为 'jd'
        Env-->>Func: 返回 'jd'
        Func->>Func: 添加 {addGlobalClass: true} 至 extraOptions
    else
        Env-->>Func: 返回其他值
    end
    Func->>Options: 合并 extraOptions 到 options 对象

Poem

我是一只活泼的兔子，
跳跃间带来新代码，
条件判断轻轻展现，
平台配置悄然上线，
快乐更新，愿梦不灭！
🐇✨

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)

We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5b53c7c and 3395327.

📒 Files selected for processing (1)

packages/taro-runtime/src/dsl/common.ts (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: Build Rust Binding / stable - aarch64-apple-darwin

🔇 Additional comments (2)

packages/taro-runtime/src/dsl/common.ts (2)

366-370: 修复方案合理，解决了JD平台的className问题

通过为JD平台添加addGlobalClass: true配置，使组件内的className能够正确生效，解决了PR中描述的问题。这种平台特定配置的方式也便于后续扩展其他平台的个性化需求。

387-388: 实现方式符合最佳实践

使用解构展开运算符（spread operator）将extraOptions合并到配置对象中是一种简洁有效的实现方式，保证了代码的可维护性和可读性。

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2025-04-11T02:35:07Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.37%. Comparing base (dcb5c43) to head (5c18ed3).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff            @@
##             main   #17511    +/-   ##
========================================
  Coverage   58.37%   58.37%            
========================================
  Files         469      469            
  Lines       27231    27231            
  Branches     5984     5944    -40     
========================================
  Hits        15896    15896            
- Misses       9807     9939   +132     
+ Partials     1528     1396   -132

Flag	Coverage Δ
taro-cli	`72.37% <ø> (ø)`
taro-runtime	`59.87% <ø> (ø)`
taro-web	`52.75% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

see 16 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

fix: 修复jd下CustomWrapper内的组件className失效问题

3395327

Single-Dancer added this to the 4.0.11 milestone Apr 11, 2025

Single-Dancer self-requested a review April 14, 2025 08:19

Single-Dancer approved these changes Apr 14, 2025

View reviewed changes

Merge branch 'main' into infix/jd-custom_wrapper-css

5c18ed3

zhengyanan1 merged commit ade74d4 into main Apr 14, 2025
24 checks passed

zhengyanan1 deleted the infix/jd-custom_wrapper-css branch April 14, 2025 10:51

Single-Dancer modified the milestones: 4.0.11, 4.0.12 Apr 14, 2025

Single-Dancer mentioned this pull request Apr 15, 2025

chore(release): publish 4.0.12 #17549

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: 修复jd下CustomWrapper内的组件className失效问题 #17511

fix: 修复jd下CustomWrapper内的组件className失效问题 #17511

Uh oh!

zhengyanan1 commented Apr 11, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Apr 11, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

codecov bot commented Apr 11, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

fix: 修复jd下CustomWrapper内的组件className失效问题 #17511

fix: 修复jd下CustomWrapper内的组件className失效问题 #17511

Uh oh!

Conversation

zhengyanan1 commented Apr 11, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

codecov bot commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

zhengyanan1 commented Apr 11, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 11, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Apr 11, 2025 •

edited

Loading