Skip to content

chore: drop rollup-plugin-ts #17480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 26, 2025
Merged

chore: drop rollup-plugin-ts #17480

merged 4 commits into from
Mar 26, 2025

Conversation

ianzone
Copy link
Contributor

@ianzone ianzone commented Mar 25, 2025

这个 PR 做了什么? (简要描述所做更改)
将 rollup-plugin-ts 改为 @rollup/plugin-typescript

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue: fix #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他，请描述(Other, please describe): 支持 node 22 的必要工作

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台（QuickApp）
  • Web 平台（H5）
  • 移动端（React-Native）
  • 鸿蒙（harmony）

@ianzone ianzone mentioned this pull request Mar 25, 2025
Closed
18 tasks
@codecov Codecov
Copy link

codecov bot commented Mar 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.86%. Comparing base (8ec6829) to head (1116c23).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17480      +/-   ##
==========================================
- Coverage   58.53%   57.86%   -0.67%     
==========================================
  Files         468      468              
  Lines       27138    26458     -680     
  Branches     5957     5798     -159     
==========================================
- Hits        15884    15309     -575     
+ Misses       9904     9575     -329     
- Partials     1350     1574     +224
Flag Coverage Δ
taro-cli 72.37% <ø> (ø)
taro-runtime 59.87% <ø> (ø)
taro-web 49.68% <ø> (-3.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 179 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

yoyo837
yoyo837 reviewed Mar 25, 2025
View reviewed changes
yoyo837
yoyo837 reviewed Mar 25, 2025
View reviewed changes
@yoyo837
Copy link
Contributor

yoyo837 commented Mar 25, 2025

大部分diff都是prettier排序问题，可否避免？

@ianzone
Copy link
Contributor Author

ianzone commented Mar 25, 2025

大部分diff都是prettier排序问题，可否避免？

要么是pnpm要么是prettier自动生成的。此次PR我可以手动调整，长期的话我希望统一使用biome进行格式化

@ianzone
Copy link
Contributor Author

ianzone commented Mar 25, 2025

格式换好了

yoyo837
yoyo837 reviewed Mar 25, 2025
View reviewed changes
yoyo837
yoyo837 reviewed Mar 25, 2025
View reviewed changes
yoyo837
yoyo837 reviewed Mar 25, 2025
View reviewed changes
yoyo837
yoyo837 reviewed Mar 26, 2025
View reviewed changes
@yoyo837
Copy link
Contributor

yoyo837 commented Mar 26, 2025

同步一下上游最新

@ianzone
Copy link
Contributor Author

ianzone commented Mar 26, 2025

欧克了

@yoyo837 yoyo837 merged commit 8256f13 into NervJS:main Mar 26, 2025
23 checks passed
@ianzone ianzone deleted the rollup branch March 30, 2025 07:59
@Single-Dancer
Copy link
Collaborator

@ianzone 同学请教下这个pr对于packages/taro-platform-h5/build/definition-json/parser.ts的改动是出于什么原因呢

@tutuxxx
Copy link
Member

tutuxxx commented Apr 14, 2025

@ianzone 这里的改动导致了一个比较严重的bug，麻烦配合 Single-Dancer 看看

@ianzone
Copy link
Contributor Author

ianzone commented Apr 14, 2025

@ianzone 这里的改动导致了一个比较严重的bug，麻烦配合 Single-Dancer 看看

收到，今晚解决

@Single-Dancer
Copy link
Collaborator

@ianzone 这里的改动导致了一个比较严重的bug，麻烦配合 Single-Dancer 看看

收到，今晚解决

这个改动导致生成的definition.json的api是空的，这个json文件的内容会传递给babel-plugin-transform-taroapi，这个babel插件会将 Taro.xxx 转换为 import { xxx } from '@tarojs/taro，由于api为空，所以没有得到转换，导致 Taro.getStorageSync 是 undefined。目前将4.0.9的definition.json的内容复制到4.0.10的项目里验证是ok的。

@yoyo837 yoyo837 mentioned this pull request Apr 14, 2025
Merged
18 tasks
Single-Dancer pushed a commit that referenced this pull request Apr 14, 2025
Revert "chore: drop rollup-plugin-ts (#17480)"
1218941 
This reverts commit 8256f13.
Single-Dancer added a commit that referenced this pull request Apr 14, 2025
@Single-Dancer
Revert "chore: drop rollup-plugin-ts (#17480)" (#17543)
b8f0e34 
This reverts commit 8256f13.

Co-authored-by: chenjiajun79 <chenjiajun79@jd.com>
ianzone added a commit to ianzone/taro that referenced this pull request Apr 14, 2025
@ianzone
Reapply "chore: drop rollup-plugin-ts (NervJS#17480)" (NervJS#17543)
ad59656 
This reverts commit b8f0e34.
Single-Dancer pushed a commit to ianzone/taro that referenced this pull request May 6, 2025
@ianzone @Single-Dancer
Reapply "chore: drop rollup-plugin-ts (NervJS#17480)" (NervJS#17543)
76dc4ed 
This reverts commit b8f0e34.
Single-Dancer pushed a commit to ianzone/taro that referenced this pull request May 6, 2025
@ianzone @Single-Dancer
Reapply "chore: drop rollup-plugin-ts (NervJS#17480)" (NervJS#17543)
e718f46 
This reverts commit b8f0e34.
yoyo837 pushed a commit that referenced this pull request May 6, 2025
@ianzone
chore：重做"替换rollup-plugin-ts插件为@rollup/plugin-typescript"
7d657e6 
* Reapply "chore: drop rollup-plugin-ts (#17480)" (#17543)

This reverts commit b8f0e34.

* fix(taro-platform-h5): 修复生成definition.json api为空

* test(babel-plugin-transform-taroapi): revert snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoyo837 yoyo837 yoyo837 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ianzone @yoyo837 @Single-Dancer @tutuxxx