Skip to content

enum_map class #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 17 commits into from
Closed

enum_map class #181

wants to merge 17 commits into from

Conversation

jlwoolf
Copy link

@jlwoolf jlwoolf commented Apr 17, 2022

I thought this could be a potential branch for the magic_enum library. It is a simple map data structure that utilizes some of the magic_enum functions to map every enum entry to a unique value.

@Neargye
Copy link
Owner

Neargye commented May 10, 2022

For updating, I didn't forget about this PR, now I'm preparing a new release 0.8.0, and this PR will be included in the next release 0.8.1

@Neargye Neargye added this to the 0.8.1 milestone May 10, 2022
@schaumb
Copy link
Contributor

schaumb commented May 12, 2022

This can be made constexpr, like I suggest here

So I think this needs an upgrade

@Neargye
Copy link
Owner

Neargye commented May 22, 2022 •
edited
Loading

it is better to keep this class in a separate header.
And I thing need all map-api begin/end find etc, #150 was just a concept idea and not advice for implementation

@Neargye Neargye modified the milestones: 0.8.1, 0.8.2 Jun 28, 2022
@Neargye Neargye removed this from the 0.8.2 milestone Aug 8, 2022
@florianbecker
Copy link
Contributor

@jlwoolf @schaumb
Can i help with that pr to make it mergeable for Neargye?

@jlwoolf
Copy link
Author

jlwoolf commented Nov 14, 2022

@florianbecker
I haven't really had the time to work on this much, so if you'd like to continue it, by all means go ahead. I can close this pull request if you'd like to open another with the improvements/fixes, or add you as a contributor to the fork.

@schaumb
Copy link
Contributor

schaumb commented Nov 14, 2022 •
edited
Loading

Hi!

I started an another PR.
I implemented already array bitset set and flat_set to namespace magic_enum::containers.

I thought I has time to implement the multiset map and flat_map too.

The array class is semantically equal to this PR.

@florianbecker florianbecker mentioned this pull request Nov 14, 2022
Merged
@Neargye
Copy link
Owner

Neargye commented Nov 14, 2022

will closed in #187

@Neargye Neargye closed this Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jlwoolf @Neargye @schaumb @florianbecker