Make OCIO SupportsOpenGL and SupportsTiles logic more consistent #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Colwell <300262+acolwell@users.noreply.github.com>
…tructor and param changes consistent. Signed-off-by: Aaron Colwell <300262+acolwell@users.noreply.github.com>
Signed-off-by: Aaron Colwell <300262+acolwell@users.noreply.github.com>
Signed-off-by: Aaron Colwell <300262+acolwell@users.noreply.github.com>
…ne with openfx naming. Signed-off-by: Aaron Colwell <300262+acolwell@users.noreply.github.com>
10 tasks
devernay
reviewed
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the setting of the SupportsOpenGL and SupportsTiles consistent between plugin creation and parameter changes. It also establishes a base class for code that is common across all of the OCIO plugins. For now I've only moved the code that directly effects the OpenGL and Tiles logic, but I believe more cleanup could likely be done.
I incremented the minor version of these plugins because this does introduce a tiny change in behavior because the construction path and parameter change paths were slightly different.