Do not discard container flags when --cuda-compat-mode is not specified #310
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jamie Liu <jamieliu@google.com>
elezar
approved these changes
May 20, 2025
This was referenced May 20, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case where no cuda-compat-mode was specified on the nvidia-container-cli configure commandline, the calculated set of flags were being CLEARED instead of setting a single bit.
This change ensures that the correct bit is set and the remaining bits are left unchanged.
This was not affecting the
nvidia-container-runtime-hook's usage of thenvidia-container-clisince we explicitly add flags in that case.Fixes: