Skip to content

Add linting #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2022
Merged

Add linting #36

merged 1 commit into from
Aug 18, 2022

Conversation

jacobtomlinson
Copy link
Member

  • Add golangci-lint via pre-commit
  • Update CI to run linting
  • Document linting
  • Couple of fixes to get linter to pass

@jacobtomlinson jacobtomlinson added enhancement New feature or request CI Related to running tests and releasing labels Aug 17, 2022
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 17, 2022
@jacobtomlinson
Add linting
82a5fca 
Signed-off-by: Jacob Tomlinson <jtomlinson@nvidia.com>
@jacobtomlinson jacobtomlinson merged commit 3569a94 into NVIDIA:main Aug 18, 2022
@jacobtomlinson jacobtomlinson deleted the precommit-lint branch August 18, 2022 10:12
@jacobtomlinson jacobtomlinson mentioned this pull request Aug 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI Related to running tests and releasing documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jacobtomlinson