Skip to content

Factor Docker container out and change command to slice #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2022
Merged

Factor Docker container out and change command to slice #14

merged 1 commit into from
Mar 24, 2022

Conversation

jacobtomlinson
Copy link
Member

  • Factor DockerContainer out of Container and introduce ContainerInterface.
  • Switch Validator.Command to a []string instead for easy passing to exec.
  • Store the command used to start the container and include it in the ContainerStatus.
  • Add more verbose debugging output.

@jacobtomlinson jacobtomlinson added the enhancement New feature or request label Mar 24, 2022
@jacobtomlinson
Factor Docker container out and change command to slice
3784fd3 
Signed-off-by: Jacob Tomlinson <jtomlinson@nvidia.com>
@jacobtomlinson jacobtomlinson merged commit 6fbddc6 into NVIDIA:main Mar 24, 2022
@jacobtomlinson jacobtomlinson deleted the command-refactor branch March 24, 2022 11:48
@jacobtomlinson jacobtomlinson mentioned this pull request Mar 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jacobtomlinson