ci: Improve no-fail-fast mechanism #13370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
chtruong814
reviewed
May 1, 2025
.github/workflows/cicd-main.yml
Outdated
| @@ -179,42 +220,49 @@ jobs: | |||
| tests_to_run: '["L0_Setup_Test_Data_And_Models"]' | |||
|
|
|||
| cicd-main-unit-tests: | |||
| needs: [pre-flight, cicd-test-container-build] | |||
| needs: [pre-flight, cicd-test-container-build, cicd-wait-in-queue] | |||
There was a problem hiding this comment.
Why do we need to add the cicd-wait-in-queue if the build step depends on it?
There was a problem hiding this comment.
We weant to run unit-tests only if the queue event was skipped, but for instance not if the build has failed.
Therefore we need a query like:
needs.pre-flight.outputs.test_to_run != '[]'
&& (
success()
|| (
needs.cicd-wait-in-queue.result == 'skipped'
&& needs.pre-flight.outputs.is_ci_workload == 'true'
)
)
&& !cancelled()
Since we want to access cicd-wait-in-queue's result attribute, we need to add it to the job's need array
.github/workflows/cicd-main.yml
Outdated
| with: | ||
| test_to_run: ${{ needs.pre-flight.outputs.test_to_run }} | ||
|
|
||
| cicd-main-export-deploy: | ||
| needs: [pre-flight, cicd-test-container-build, cicd-main-unit-tests] | ||
| uses: ./.github/workflows/cicd-main-export-deploy.yml | ||
| if: | | ||
| (success() || needs.cicd-wait-in-queue.result == 'skipped') && (contains(fromJson(needs.pre-flight.outputs.components_to_run), 'export-deploy') || needs.pre-flight.outputs.components_to_run == '["all"]') | ||
| (success() || (needs.cicd-wait-in-queue.result == 'skipped' && needs.pre-flight.outputs.is_ci_workload == 'true') || needs.pre-flight.outputs.no_fail_fast == 'true') && (contains(fromJson(needs.pre-flight.outputs.components_to_run), 'export-deploy') || needs.pre-flight.outputs.components_to_run == '["all"]') |
There was a problem hiding this comment.
Why should we have both is_ci_workload mechanisms rather than relying on the no-fail-fast label like we did before?
There was a problem hiding this comment.
Open for discussion, my thinking was that no-fail-fast is a label that also engineers can attach. We don't want to let them bypass approval though. CI-workloads make use of no-fail-fast but also get an express lane on the CI. So it's two different mechanisms that we need
Signed-off-by: oliver könig <okoenig@nvidia.com>
chtruong814
approved these changes
May 1, 2025
yuanzhedong
pushed a commit
that referenced
this pull request
May 1, 2025
* ci: Improve no-fail-fast mechanism Signed-off-by: oliver könig <okoenig@nvidia.com> * f Signed-off-by: oliver könig <okoenig@nvidia.com> * maybe like this? Signed-off-by: oliver könig <okoenig@nvidia.com> * test Signed-off-by: oliver könig <okoenig@nvidia.com> * fix Signed-off-by: oliver könig <okoenig@nvidia.com> * fix Signed-off-by: oliver könig <okoenig@nvidia.com> * test Signed-off-by: oliver könig <okoenig@nvidia.com> * test Signed-off-by: oliver könig <okoenig@nvidia.com> * test Signed-off-by: oliver könig <okoenig@nvidia.com> * fix Signed-off-by: oliver könig <okoenig@nvidia.com> * jobs Signed-off-by: oliver könig <okoenig@nvidia.com> * revert debugging Signed-off-by: oliver könig <okoenig@nvidia.com> * test Signed-off-by: oliver könig <okoenig@nvidia.com> * fix Signed-off-by: oliver könig <okoenig@nvidia.com> --------- Signed-off-by: oliver könig <okoenig@nvidia.com> Signed-off-by: Yuanzhe Dong <yudong@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information