[Automodel] Fix CP device_mesh issue, use PTL distsampler (#13473) #13636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix dp_cp mesh usage Signed-off-by: Boxiang Wang <boxiangw@nvidia.com> * Apply isort and black reformatting Signed-off-by: BoxiangW <BoxiangW@users.noreply.github.com> * Remove hf_dataset dist_sampler, let PTL handle the dist_sampler instead Signed-off-by: Boxiang Wang <boxiangw@nvidia.com> * Remove print Signed-off-by: Boxiang Wang <boxiangw@nvidia.com> * Apply isort and black reformatting Signed-off-by: BoxiangW <BoxiangW@users.noreply.github.com> * Deal with CP on all padding ranks Signed-off-by: Boxiang Wang <boxiangw@nvidia.com> * Apply isort and black reformatting Signed-off-by: BoxiangW <BoxiangW@users.noreply.github.com> * Remove unused import Signed-off-by: Boxiang Wang <boxiangw@nvidia.com> * update loss nan conversion Signed-off-by: Boxiang Wang <boxiangw@nvidia.com> * Change dp_cp mesh check Signed-off-by: Boxiang Wang <boxiangw@nvidia.com> * Apply isort and black reformatting Signed-off-by: BoxiangW <BoxiangW@users.noreply.github.com> * Fix dp_cp check bug Signed-off-by: Boxiang Wang <boxiangw@nvidia.com> * Update automodel.py Signed-off-by: BoxiangW <boxiangw@nvidia.com> * Add conversion to int for parallel sizes Signed-off-by: Boxiang Wang <boxiangw@nvidia.com> * Apply isort and black reformatting Signed-off-by: BoxiangW <BoxiangW@users.noreply.github.com> --------- Signed-off-by: Boxiang Wang <boxiangw@nvidia.com> Signed-off-by: BoxiangW <BoxiangW@users.noreply.github.com> Signed-off-by: BoxiangW <boxiangw@nvidia.com> Co-authored-by: BoxiangW <BoxiangW@users.noreply.github.com>
chtruong814
previously approved these changes
May 18, 2025
Signed-off-by: Alexandros Koumparoulis <153118171+akoumpa@users.noreply.github.com>
chtruong814
approved these changes
May 19, 2025
|
[🤖]: Hi @akoumpa 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully So it might be time to merge this PR or get some approvals I'm just a bot so I'll leave it you what to do next. //cc @pablo-garay @ko3n1g |
|
@chtruong814 let's merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix dp_cp mesh usage
Apply isort and black reformatting
Remove hf_dataset dist_sampler, let PTL handle the dist_sampler instead
Remove print
Apply isort and black reformatting
Deal with CP on all padding ranks
Apply isort and black reformatting
Remove unused import
update loss nan conversion
Change dp_cp mesh check
Apply isort and black reformatting
Fix dp_cp check bug
Update automodel.py
Add conversion to int for parallel sizes
Apply isort and black reformatting
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information