Chtruong/r2.3.0 cherry picks #13615
Closed
Chtruong/r2.3.0 cherry picks #13615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add end to end test for local checkpoint Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * lints Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * lints Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * lints Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * update tests Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * lint Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * lints Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * lints Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * Update tests/functional_tests/L2_NeMo_2_llama3_local_ckpt.sh Signed-off-by: Ananth Subramaniam <ananth.subramaniam@gmail.com> Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * address comments from review Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * update test script Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * update test Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * lint Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * clean up assertions in log Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * combine converage files Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * use nemo run for test launch Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * rebase after new CI workflow change Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> * Apply isort and black reformatting Signed-off-by: ananthsub <ananthsub@users.noreply.github.com> * Update .github/workflows/cicd-main-nemo2.yml Signed-off-by: Ananth Subramaniam <ananth.subramaniam@gmail.com> --------- Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com> Signed-off-by: Ananth Subramaniam <ananth.subramaniam@gmail.com> Signed-off-by: ananthsub <ananthsub@users.noreply.github.com> Co-authored-by: ananthsub <ananthsub@users.noreply.github.com> Co-authored-by: oliver könig <okoenig@nvidia.com> Signed-off-by: Charlie Truong <chtruong@nvidia.com>
* run global_batch_size Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * fix Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * Apply isort and black reformatting Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> --------- Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> Co-authored-by: akoumpa <akoumpa@users.noreply.github.com> Co-authored-by: Charlie Truong <chtruong@nvidia.com> Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: ko3n1g <ko3n1g@users.noreply.github.com> Signed-off-by: Charlie Truong <chtruong@nvidia.com>
* fix Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * make fp8 tests non-optional Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * switch to gemma Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> --------- Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> Co-authored-by: oliver könig <okoenig@nvidia.com> Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> Signed-off-by: Charlie Truong <chtruong@nvidia.com>
* fixed --mbs/gbs dtype and chat-template Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * add things back Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * add things back Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * fix Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * fix Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * use kwargs Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * fix Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * Apply isort and black reformatting Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> --------- Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> Signed-off-by: akoumpa <akoumpa@users.noreply.github.com> Co-authored-by: akoumpa <akoumpa@users.noreply.github.com> Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <153118171+akoumpa@users.noreply.github.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: akoumpa <akoumpa@users.noreply.github.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
… into chtruong/r2.3.0-cherry-picks
|
[🤖]: Hi @chtruong814 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully So it might be time to merge this PR or get some approvals I'm just a bot so I'll leave it you what to do next. //cc @pablo-garay @ko3n1g |
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
This was referenced May 16, 2025
Merged
|
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
|
This PR was closed because it has been inactive for 7 days since being marked as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information