Skip to content

ci: Run selective triggering on dockerfiles and dependencies #13493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025

Conversation

ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented May 8, 2025

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: oliver könig <okoenig@nvidia.com>
@ko3n1g ko3n1g merged commit 28db904 into main May 8, 2025
33 of 34 checks passed
@ko3n1g ko3n1g deleted the ko3n1g/ci/selective-triggering-5 branch May 8, 2025 00:36
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request May 9, 2025
…13493)

Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>
nithinraok pushed a commit that referenced this pull request May 12, 2025
* added use-fast tokenizer argument (#12986)

Signed-off-by: Francesco Bertolotti <f14.bertolotti@gmail.com>
Co-authored-by: Alexandros Koumparoulis <153118171+akoumpa@users.noreply.github.com>
Co-authored-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>

* ci: Run selective triggering on dockerfiles and dependencies (#13493)

Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>

* fix buffered inference for tdt

Signed-off-by: Hainan Xu <hainanx@nvidia.com>

* small fixes

Signed-off-by: Hainan Xu <hainanx@nvidia.com>

* [automodel] fallback FP8 + LCE -> FP8 + CE  (#13349)

* fix

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* make fp8 tests non-optional

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* switch to gemma

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

---------

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Co-authored-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>

* Update changelog for `r2.3.0` (#13501)

* beep boop: Update changelog

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Add changelog highlights

Signed-off-by: Charlie Truong <chtruong@nvidia.com>

---------

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>

* Update 2.3.0 changelog (#13503)

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>

* ci: Remove trt-llm breakpoint (#13499)

* tests: Disable flaky test

Signed-off-by: oliver könig <okoenig@nvidia.com>

* remove breakpoint

Signed-off-by: oliver könig <okoenig@nvidia.com>

---------

Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>

* Update 2.3.0 changelog (#13504)

* Fix 2.3.0 changelog

Signed-off-by: Charlie Truong <chtruong@nvidia.com>

* Update 2.3.0 changelog

Signed-off-by: Charlie Truong <chtruong@nvidia.com>

---------

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>

* Enabling flash decode for float16 precision only (#13471)

Signed-off-by: Pranav Prashant Thombre <pthombre@nvidia.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>

* Fix changelog formatting (#13505)

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>

* Updating the long context performance number for B200 (#13468)

* Add without CP numbers for B200 and merge the captioning texts of both into one.

Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com>

* figure removed

Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com>

---------

Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>

* Autodetect model_type and dtype for deployment using TRT-LLM backend (#13209)

* Autodetect model_type and dtype for deployment using TRT-LLM backed

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

* Handling kv_cache_qformat parameter

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

* Apply isort and black reformatting

Signed-off-by: janekl <janekl@users.noreply.github.com>

* Docstring update

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

---------

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: janekl <janekl@users.noreply.github.com>
Co-authored-by: janekl <janekl@users.noreply.github.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>

* remove unused variable

Signed-off-by: Hainan Xu <hainanx@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: hainan-xv <hainan-xv@users.noreply.github.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>

* add doc string, cleaner way of setting mergo_algo

Signed-off-by: Hainan Xu <hainanx@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: hainan-xv <hainan-xv@users.noreply.github.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>

* add extra hyena tests (#13097)

* add extra hyena tests

* Apply isort and black reformatting

Signed-off-by: JRD971000 <JRD971000@users.noreply.github.com>

* fix num gpus

* keep sft optional

---------

Signed-off-by: JRD971000 <JRD971000@users.noreply.github.com>
Co-authored-by: JRD971000 <JRD971000@users.noreply.github.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>

* ci: Add mode files to filter (#13517)

Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>

* change default merge_algo for buffered inference to None

Signed-off-by: Hainan Xu <hainanx@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: hainan-xv <hainan-xv@users.noreply.github.com>

---------

Signed-off-by: Francesco Bertolotti <f14.bertolotti@gmail.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Pranav Prashant Thombre <pthombre@nvidia.com>
Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com>
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: janekl <janekl@users.noreply.github.com>
Signed-off-by: hainan-xv <hainan-xv@users.noreply.github.com>
Signed-off-by: JRD971000 <JRD971000@users.noreply.github.com>
Co-authored-by: Francesco Bertolotti <f14.bertolotti@gmail.com>
Co-authored-by: Alexandros Koumparoulis <153118171+akoumpa@users.noreply.github.com>
Co-authored-by: oliver könig <okoenig@nvidia.com>
Co-authored-by: Hainan Xu <hainanx@nvidia.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Charlie Truong <chtruong@nvidia.com>
Co-authored-by: pthombre <pthombre@nvidia.com>
Co-authored-by: Youngeun Kwon <youngeunk@nvidia.com>
Co-authored-by: Jan Lasek <janek.lasek@gmail.com>
Co-authored-by: janekl <janekl@users.noreply.github.com>
Co-authored-by: hainan-xv <hainan-xv@users.noreply.github.com>
Co-authored-by: Ali Taghibakhshi <71892896+JRD971000@users.noreply.github.com>
Co-authored-by: JRD971000 <JRD971000@users.noreply.github.com>
shjwudp pushed a commit to shjwudp/NeMo that referenced this pull request May 31, 2025
* added use-fast tokenizer argument (NVIDIA#12986)

Signed-off-by: Francesco Bertolotti <f14.bertolotti@gmail.com>
Co-authored-by: Alexandros Koumparoulis <153118171+akoumpa@users.noreply.github.com>
Co-authored-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>

* ci: Run selective triggering on dockerfiles and dependencies (NVIDIA#13493)

Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>

* fix buffered inference for tdt

Signed-off-by: Hainan Xu <hainanx@nvidia.com>

* small fixes

Signed-off-by: Hainan Xu <hainanx@nvidia.com>

* [automodel] fallback FP8 + LCE -> FP8 + CE  (NVIDIA#13349)

* fix

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* make fp8 tests non-optional

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* switch to gemma

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

---------

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Co-authored-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>

* Update changelog for `r2.3.0` (NVIDIA#13501)

* beep boop: Update changelog

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Add changelog highlights

Signed-off-by: Charlie Truong <chtruong@nvidia.com>

---------

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>

* Update 2.3.0 changelog (NVIDIA#13503)

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>

* ci: Remove trt-llm breakpoint (NVIDIA#13499)

* tests: Disable flaky test

Signed-off-by: oliver könig <okoenig@nvidia.com>

* remove breakpoint

Signed-off-by: oliver könig <okoenig@nvidia.com>

---------

Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>

* Update 2.3.0 changelog (NVIDIA#13504)

* Fix 2.3.0 changelog

Signed-off-by: Charlie Truong <chtruong@nvidia.com>

* Update 2.3.0 changelog

Signed-off-by: Charlie Truong <chtruong@nvidia.com>

---------

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>

* Enabling flash decode for float16 precision only (NVIDIA#13471)

Signed-off-by: Pranav Prashant Thombre <pthombre@nvidia.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>

* Fix changelog formatting (NVIDIA#13505)

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>

* Updating the long context performance number for B200 (NVIDIA#13468)

* Add without CP numbers for B200 and merge the captioning texts of both into one.

Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com>

* figure removed

Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com>

---------

Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>

* Autodetect model_type and dtype for deployment using TRT-LLM backend (NVIDIA#13209)

* Autodetect model_type and dtype for deployment using TRT-LLM backed

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

* Handling kv_cache_qformat parameter

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

* Apply isort and black reformatting

Signed-off-by: janekl <janekl@users.noreply.github.com>

* Docstring update

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>

---------

Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: janekl <janekl@users.noreply.github.com>
Co-authored-by: janekl <janekl@users.noreply.github.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>

* remove unused variable

Signed-off-by: Hainan Xu <hainanx@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: hainan-xv <hainan-xv@users.noreply.github.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>

* add doc string, cleaner way of setting mergo_algo

Signed-off-by: Hainan Xu <hainanx@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: hainan-xv <hainan-xv@users.noreply.github.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>

* add extra hyena tests (NVIDIA#13097)

* add extra hyena tests

* Apply isort and black reformatting

Signed-off-by: JRD971000 <JRD971000@users.noreply.github.com>

* fix num gpus

* keep sft optional

---------

Signed-off-by: JRD971000 <JRD971000@users.noreply.github.com>
Co-authored-by: JRD971000 <JRD971000@users.noreply.github.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>

* ci: Add mode files to filter (NVIDIA#13517)

Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>

* change default merge_algo for buffered inference to None

Signed-off-by: Hainan Xu <hainanx@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: hainan-xv <hainan-xv@users.noreply.github.com>

---------

Signed-off-by: Francesco Bertolotti <f14.bertolotti@gmail.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Pranav Prashant Thombre <pthombre@nvidia.com>
Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com>
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: janekl <janekl@users.noreply.github.com>
Signed-off-by: hainan-xv <hainan-xv@users.noreply.github.com>
Signed-off-by: JRD971000 <JRD971000@users.noreply.github.com>
Co-authored-by: Francesco Bertolotti <f14.bertolotti@gmail.com>
Co-authored-by: Alexandros Koumparoulis <153118171+akoumpa@users.noreply.github.com>
Co-authored-by: oliver könig <okoenig@nvidia.com>
Co-authored-by: Hainan Xu <hainanx@nvidia.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Charlie Truong <chtruong@nvidia.com>
Co-authored-by: pthombre <pthombre@nvidia.com>
Co-authored-by: Youngeun Kwon <youngeunk@nvidia.com>
Co-authored-by: Jan Lasek <janek.lasek@gmail.com>
Co-authored-by: janekl <janekl@users.noreply.github.com>
Co-authored-by: hainan-xv <hainan-xv@users.noreply.github.com>
Co-authored-by: Ali Taghibakhshi <71892896+JRD971000@users.noreply.github.com>
Co-authored-by: JRD971000 <JRD971000@users.noreply.github.com>
Signed-off-by: jianbinc <shjwudp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants