Update exp_manager to better handle parallelism #12211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paarth Neekhara <paarth.n@gmail.com>
|
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
|
This PR was closed because it has been inactive for 7 days since being marked as stale. |
blisc
previously approved these changes
Mar 12, 2025
Signed-off-by: Jason <jasoli@nvidia.com>
blisc
approved these changes
Mar 12, 2025
yuanzhedong
pushed a commit
that referenced
this pull request
Mar 18, 2025
Signed-off-by: Paarth Neekhara <pneekhara@nvidia.com> Signed-off-by: Jason <jasoli@nvidia.com> Co-authored-by: Jason <jasoli@nvidia.com> Signed-off-by: Yuanzhe Dong <yudong@nvidia.com>
yuanzhedong
added a commit
that referenced
this pull request
Mar 23, 2025
* Update exp_manager to better handle parallelism (#12211) Signed-off-by: Paarth Neekhara <pneekhara@nvidia.com> Signed-off-by: Jason <jasoli@nvidia.com> Co-authored-by: Jason <jasoli@nvidia.com> Signed-off-by: Yuanzhe Dong <yudong@nvidia.com> * Add Neva support for VLM inference (#12531) * Add Neva support for vlm inference * Apply isort and black reformatting Signed-off-by: meatybobby <meatybobby@users.noreply.github.com> * keep legacy generate --------- Signed-off-by: meatybobby <meatybobby@users.noreply.github.com> Signed-off-by: meatybobby <bobchen@nvidia.com> Co-authored-by: meatybobby <meatybobby@users.noreply.github.com> Signed-off-by: Yuanzhe Dong <yudong@nvidia.com> * fix automodle benchmark script Signed-off-by: Yuanzhe Dong <yudong@nvidia.com> * use hf mock dataset Signed-off-by: Yuanzhe Dong <yudong@nvidia.com> --------- Signed-off-by: Paarth Neekhara <pneekhara@nvidia.com> Signed-off-by: Jason <jasoli@nvidia.com> Signed-off-by: Yuanzhe Dong <yudong@nvidia.com> Signed-off-by: meatybobby <meatybobby@users.noreply.github.com> Signed-off-by: meatybobby <bobchen@nvidia.com> Co-authored-by: Paarth Neekhara <paarth.n@gmail.com> Co-authored-by: Jason <jasoli@nvidia.com> Co-authored-by: meatybobby <bobchen@nvidia.com> Co-authored-by: meatybobby <meatybobby@users.noreply.github.com>
cspades
pushed a commit
that referenced
this pull request
Mar 24, 2025
* Update exp_manager to better handle parallelism (#12211) Signed-off-by: Paarth Neekhara <pneekhara@nvidia.com> Signed-off-by: Jason <jasoli@nvidia.com> Co-authored-by: Jason <jasoli@nvidia.com> Signed-off-by: Yuanzhe Dong <yudong@nvidia.com> * Add Neva support for VLM inference (#12531) * Add Neva support for vlm inference * Apply isort and black reformatting Signed-off-by: meatybobby <meatybobby@users.noreply.github.com> * keep legacy generate --------- Signed-off-by: meatybobby <meatybobby@users.noreply.github.com> Signed-off-by: meatybobby <bobchen@nvidia.com> Co-authored-by: meatybobby <meatybobby@users.noreply.github.com> Signed-off-by: Yuanzhe Dong <yudong@nvidia.com> * fix automodle benchmark script Signed-off-by: Yuanzhe Dong <yudong@nvidia.com> * use hf mock dataset Signed-off-by: Yuanzhe Dong <yudong@nvidia.com> --------- Signed-off-by: Paarth Neekhara <pneekhara@nvidia.com> Signed-off-by: Jason <jasoli@nvidia.com> Signed-off-by: Yuanzhe Dong <yudong@nvidia.com> Signed-off-by: meatybobby <meatybobby@users.noreply.github.com> Signed-off-by: meatybobby <bobchen@nvidia.com> Co-authored-by: Paarth Neekhara <paarth.n@gmail.com> Co-authored-by: Jason <jasoli@nvidia.com> Co-authored-by: meatybobby <bobchen@nvidia.com> Co-authored-by: meatybobby <meatybobby@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update exp_manager.py to manage two things: