Skip to content

GHA CI test: Remove unnecessary directive #12714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2025
Merged

Conversation

pablo-garay
Copy link
Collaborator

@pablo-garay pablo-garay commented Mar 20, 2025

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

This is a follow up PR

GHA CI test: Remove unnecessary directive
The line executes in the container which is discarded later anyways . So no need to do that

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Pablo Garay <palenq@gmail.com>
@pablo-garay pablo-garay requested a review from abhinavg4 March 20, 2025 16:37
@github-actions github-actions bot added the CI label Mar 20, 2025
@pablo-garay pablo-garay enabled auto-merge (squash) March 20, 2025 16:38
@pablo-garay pablo-garay disabled auto-merge March 20, 2025 16:41
@pablo-garay pablo-garay merged commit 8573256 into main Mar 20, 2025
31 checks passed
@pablo-garay pablo-garay deleted the pablo-garay-tidy-code branch March 20, 2025 16:41
cspades pushed a commit that referenced this pull request Mar 24, 2025
Signed-off-by: Pablo Garay <palenq@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants