Skip to content

ObjectGraphScanner - Handle property-getter that throws when AOT #5651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Oct 21, 2024

Handle situation where failing to correctly register NLog extensions for build-trimming.

See also: getsentry/sentry-dotnet#3680

@snakefoot snakefoot added the enhancement Improvement on existing feature label Oct 21, 2024
@snakefoot snakefoot added this to the 5.4 milestone Oct 21, 2024
@snakefoot snakefoot changed the title ObjectGraphScanner - Property-getter-methods that throws when AOT ObjectGraphScanner - Handle property-getter that throws when AOT Oct 21, 2024
@snakefoot snakefoot closed this Oct 21, 2024
@snakefoot snakefoot reopened this Oct 21, 2024
@snakefoot snakefoot force-pushed the master branch 5 times, most recently from 04bd490 to e2ecdf1 Compare October 21, 2024 19:08
@pull-request-size pull-request-size bot added size/M and removed size/S labels Oct 21, 2024
@snakefoot snakefoot force-pushed the master branch 3 times, most recently from a566092 to f14cb24 Compare October 21, 2024 19:22
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
50.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@snakefoot snakefoot merged commit adc276c into NLog:master Oct 21, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement on existing feature size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant