Skip to content

Conversation

hahnd
Copy link
Contributor

@hahnd hahnd commented Sep 6, 2024

Pull Request Testing

  • Describe testing already performed for these changes:

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]

  • Do these changes include sufficient testing updates? [Yes or No]

  • Will this PR result in changes to the test suite? [Yes or No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development issue with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@georgemccabe
Copy link
Contributor

@briannen, I merged changes from main to fix the documentation build failures. Could you take a look at these changes and provide a review? I wonder if this content should go at the top of the docs/Users_Guide/running.rst file instead of its own file?

Copy link
Contributor

@briannen briannen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall:

Line by Line:

  • 24-25: Talks about Jetstream2, but these are directions for Derecho.
  • 64: Change Singularity to Apptainer
  • 73: Change singularity to apptainer
  • 100: Change singularity to apptainer
  • 103: Change singularity to apptainer

@jaredalee jaredalee mentioned this pull request Aug 1, 2025
30 tasks
@georgemccabe
Copy link
Contributor

I moved the new content from the PR to the appropriate location following the new format of the use case instructions. I made the suggested changes from this PR and modified the instructions to more closely match the instructions for the other platforms. I also pulled out common content that can be included in multiple sets of instructions to reduce redundancy.

Someone should run through these instructions on Derecho to make sure that everything works as expected.

Updated instructions can be found here:
https://i-wrf--62.org.readthedocs.build/en/62/Users_Guide/use-cases/matthew.html#on-nsf-ncar-hpc

@georgemccabe georgemccabe requested a review from jaredalee August 15, 2025 22:21
… derecho to be clear which HPC these instructions have been written for
Copy link
Contributor

@jaredalee jaredalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After resolving the remaining two minor comments/suggestions, this will be ready for approval. Thanks, @georgemccabe!

…rs that portions of the runs may take some time to complete and what to look for to continue instructions
@georgemccabe
Copy link
Contributor

@jaredalee , I made the changes you suggested and added a section to describe how to view a few images. Take a look at the latest version and let me know if these look good to you or if you have any other suggestions for edits.

@georgemccabe georgemccabe requested a review from jaredalee August 18, 2025 22:03
Copy link
Contributor

@jaredalee jaredalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for making those additions, @georgemccabe.

@georgemccabe georgemccabe merged commit 518dfb0 into main Aug 18, 2025
3 checks passed
@georgemccabe georgemccabe deleted the feature/doc-derecho-wrf2 branch August 18, 2025 22:18
@georgemccabe georgemccabe linked an issue Aug 18, 2025 that may be closed by this pull request
20 tasks
@georgemccabe georgemccabe added this to the I-WRF 0.1.0 milestone Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants