Skip to content

Conversation

georgemccabe
Copy link
Contributor

@georgemccabe georgemccabe commented May 21, 2024

Pull Request Testing

  • Describe testing already performed for these changes:

Ran instructions on casper with a clean environment

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Follow instructions to run METplus use case on casper: https://i-wrf.readthedocs.io/en/feature-48_matthew_metplus/Users_Guide/running.html#on-an-hpc-cluster-with-apptainer
Note: After cloning the i-wrf GitHub repository, you will need to switch to the feature branch to get the METplus config file needed to run the use case

git -C ${SCRATCH}/i-wrf checkout feature/48_matthew_metplus

Also note: The instructions use the development version of METplus (dtcenter/metplus-dev:develop). Once the next METplus release has been created, we will need to update the instructions to replace metplus-dev:develop with metplus:6.0.0 to ensure that the stable release is always used.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [N/A]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by 5/22/2024.

Pull Request Checklist

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development issue with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

…eparately (until dtcenter/METplus#2567 is completed). Adjust settings to produce more useful output, prevent wind vector warnings, filter out duplicate obs, define pressure levels, etc.
…vel value and change output flag settings to get results that can be more easily plotted
…ntainer that are mounted -- left paths on casper for reference
…s, added steps to clone i-wrf repo to get METplus config files
@georgemccabe georgemccabe added this to the I-WRF 0.1.0 milestone May 21, 2024
@georgemccabe georgemccabe requested a review from jaredalee May 21, 2024 14:11
@georgemccabe georgemccabe linked an issue May 21, 2024 that may be closed by this pull request
20 tasks
@jaredalee jaredalee merged commit 743b9b7 into main May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run Hurricane Matthew test case in METplus container
2 participants