-
Notifications
You must be signed in to change notification settings - Fork 4
Closed
Description
I looked into the new homebrew formula: https://github.com/ivanperez-keera/homebrew-core/blob/master/Formula/ikos.rb
There are a few things I would like to address:
- Right now, we are effectively installing 2 virtual environments: virtualenv_create creates one and
make install
creates another one - We are not following the homebrew guidelines for python virtual envs: https://docs.brew.sh/Python-for-Formula-Authors
This is what I think we should do:
- Use
virtualenv_create
- Call cmake with
-DINSTALL_PYTHON_VIRTUALENV=OFF
and-DPYTHON_VENV_EXECUTABLE=#{libexec}/vendor/bin/python
- After
make install
, call#{libexec}/vendor/bin/python -m pip install .
inbuild/analyzer/python
to install the ikos python package in the homebrew-created virtualenv (or better, https://docs.brew.sh/Python-for-Formula-Authors#installing-bindings) - Use
venv.pip_install resources
to install pygments, the same way we did it before
I don't have time to try today but I could try later this week.
Metadata
Metadata
Assignees
Labels
No labels