Fix flags causing service to not start. #631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- It needed the first arg to be the exe path. - Did a refactor in the process to make things look nicer
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #631 +/- ##
=======================================
Coverage 78.01% 78.01%
=======================================
Files 96 96
Lines 6786 6786
=======================================
Hits 5294 5294
Misses 1492 1492 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Still a draft at the moment. I'll mark it ready once I feel I'm good to proceed. |
|
I have done some testing, and it appears to work properly. Should be ready to go! 😄 |
|
Awesome, thanks :) In it goes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #630 . After checking, flags indeed were causing the service start up fail. I have now tested them properly and fixed the issue.
The issue was that the rust binary expects the first arg to be the current exe, e.g.
"C:\my-current-exe.exe", but I was not giving it.This full expanded command now works (including profile too if specified).
R:\path\to\pueued.exe --config C:\path\to\pueue.yml service runI did a small refactor in the process, cause why not
Checklist
Please make sure the PR adheres to this project's standards:
CHANGELOG.md.cargo clippyandcargo fmt. The CI will fail otherwise anyway.