Fix extraneous double quotes in Windows service #630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ags in Windows service install
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #630 +/- ##
=======================================
Coverage 78.01% 78.01%
=======================================
Files 96 96
Lines 6786 6786
=======================================
Hits 5294 5294
Misses 1492 1492 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks, 4.0.1 is also correct 👍 I'll release a patch version for it soonish then :) |
Could we hold off on the next patch release for a moment? I have one more related area I want to be certain is correct (it didn't make it into this PR yet; I realized this a little later after I opened it) |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
pueued -c "space path" service install, the service cli got expanded topueued --config "\"space path\"" service run, which is definitely not correct. Turns out that thewindows_servicecrate already handled the case of spaces in the arg for us. Nice. This PR fixes this bug. Now it expands topueued --config "space path" service runorpueued --config no_space_path service run(I don't know the next version for the changelog, but I assumed it's 4.0.1. Please let me know if the changelog entry needs to be fixed)
TODO:
pueue/pueue/src/daemon/service.rs
Line 634 in 33290e6
Checklist
Please make sure the PR adheres to this project's standards:
CHANGELOG.md.cargo clippyandcargo fmt. The CI will fail otherwise anyway.