Skip to content

Conversation

Nukesor
Copy link
Owner

@Nukesor Nukesor commented Feb 1, 2025

Fixes #553

@Nukesor Nukesor self-assigned this Feb 1, 2025
@Nukesor Nukesor mentioned this pull request Feb 1, 2025
Copy link

github-actions bot commented Feb 1, 2025

Test Results

  3 files  ±0   19 suites  ±0   3m 14s ⏱️ +2s
164 tests +1  164 ✅ +1  0 💤 ±0  0 ❌ ±0 
346 runs  +2  346 ✅ +2  0 💤 ±0  0 ❌ ±0 

Results for commit c5e0b47. ± Comparison against base commit fbca708.

This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.
pueue::tests ‑ client::integration::edit::edit_task_default
pueue::tests ‑ client::integration::edit::edit_task_directory
pueue::tests ‑ client::integration::edit::edit_task_toml

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Feb 1, 2025

Codecov Report

Attention: Patch coverage is 96.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.34%. Comparing base (fbca708) to head (c5e0b47).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
pueue/src/client/commands/edit.rs 96.55% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #598      +/-   ##
==========================================
+ Coverage   79.22%   79.34%   +0.12%     
==========================================
  Files          74       74              
  Lines        5940     5980      +40     
==========================================
+ Hits         4706     4745      +39     
- Misses       1234     1235       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nukesor Nukesor merged commit e0dbceb into main Feb 2, 2025
19 checks passed
@Nukesor Nukesor deleted the toml-task-editing branch February 2, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance pueue edit UX
1 participant