-
Notifications
You must be signed in to change notification settings - Fork 26
Description
Hello @MorrisonCole,
First off, many thanks for creating and publishing this Action. We've been using it on our private repos and find it super useful! 🙌
I did find a small issue though, and it has to do with PR statuses.
When my PR lint check fails and I update the title of my PR, a subsequent passing check doesn't set the PR status to 'All checks passed'. You can also see this in the screenshot below from your example PR.
Normally, we don't merge a PR unless all checks have passed, and this is showing up some 'false failures'(when subsequent checks have passed).
I did have a look at the source code for the action, and it seems to me that maybe explicitly setting the status to passed when the title matches the regex might help? @github/core doesn't seem to provide a method to do this though.
What are your thoughts?