Updated installer script #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the installer script to improve its usability and maintainability.
- Simplifies variable definitions by replacing dynamic app name manipulation with a static string.
- Refines profile detection logic by reordering the search sequence and clarifying comments.
- Enhances the PATH update process with clearer feedback, including handling the case where no profile is detected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the
install.shscript to improve usability and maintainability. The changes include simplifying variable definitions, refining profile detection logic, and enhancing feedback during the PATH update process.Improvements to variable definitions:
fullAppNamevariable by replacing the dynamic string manipulation with a static value, changing it from a computed string to"Ferret CLI". (install.sh, install.shL11-R11)Refinements to profile detection logic:
detect_profilefunction to clarify that the script avoids modifying the user's profile if explicitly requested. (install.sh, install.shL77-R77)detect_profilefunction to prioritize.zshrcover.profile. (install.sh, install.shL99-R99)Enhancements to PATH update process:
update_profilefunction to handle cases where no profile is detected, providing a clear message and skipping the PATH update if necessary. Additionally, added feedback to inform users whether the specified location is already in the PATH. (install.sh, install.shL116-R124)