Feature/nickmkk 55 nuget packagereference compatibility #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickmkk
commented
Aug 9, 2018
- I've updated the MongoBinaryLocator to look for binaries in the nuget cache if they are not found in the project directory. This will make Mongo2Go compatible with projects using the nuget PackageReference option.
- Also, I've added a binariesSearchDirectory parameter to MongoDbRunner.Start which allows an additional binaries search directory to be provided. This will make the db runner more flexible if someone decides to use it in some unpredictable way.
added 3 commits
August 9, 2018 10:19
…nuget cache if they are not found in the project directory. This will make Mongo2Go compatible with projects using the nuget PackageReference option.
…h allows the binaries search directory to be provided
|
That looks pretty fine! 👍 |
|
v2.2.7 is out! Many thanks! 👍 |
|
No problem, thank for merging, testing, and deploying it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.