Skip to content

Conversation

perliedman
Copy link

This updates target framework to netcorapp2.0 and updates dependencies (Machine.Specifications and Microsoft.NET.Test.Sdk). This, in combination with #42, makes the tests possible to run for me on Windows as well as Linux.

I should say I find the combinations of .NET Core and .NET Standard very confusing, so I apologize in advance if I've messed something up. Also, some tool appears to have changed indentation on everything 😞 .

@JohannesHoppe
Copy link
Member

... and than Linux magically starts to work again? o_O

@perliedman
Copy link
Author

Yeah, sorry not being able to explain why this works, but at least on my machine this makes it work.

I've had a lot of trouble with "old" projects with unit tests, where upgrading the test frameworks and VS integration packages makes a lot of difference. I don't know enough about the changes MS made in the last iterations of .NET Core, but I guess they changed something important.

@JohannesHoppe
Copy link
Member

In our case the tests were just disabled. In the beginning there was no Runner for .NET Core at all.
You solved that be adding the correct runner again. (see https://github.com/machine/machine.specifications/wiki/.NET-Core-(.NET-CLI)) I'm pretty sure that it would also work with .NET core 1.0. But 2.0 is fine, too! 👍

@perliedman
Copy link
Author

Not exactly sure why we're seeing those build failures in Travis - it looks like it's importing multiple versions of the same assembly for some reason. 😕

@JohannesHoppe JohannesHoppe merged commit 85c9c60 into Mongo2Go:master Nov 23, 2017
@perliedman perliedman deleted the netcore2.0-tests branch May 30, 2018 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants