Skip to content

Migrate to .NET Standard 1.6 #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2016
Merged

Migrate to .NET Standard 1.6 #25

merged 1 commit into from
Dec 19, 2016

Conversation

bannerflow-hassaan
Copy link
Contributor

Purpose of this PR is to migrate from .NET Framework 4.6 to .NET Standard 1.6. Here are some key takeaways from migration.

  • .NET Portability Analyzer is a neat VS plugin to run on existing projects and find out if its even worth trying to port.
  • Reverse Package Search is extremely useful when it comes to finding classes, namespaces and their target framework compatibilities.
  • .NET Core doesn't support Binary Serialization (yet), hence Serializable attributes were removed as described in this StackOverflow post.
  • ProcessStartInfo.WindowStyle as well as Process.MainWindowHandle are not supported.
  • MSpec has a known issue with Test Runner and VS IDE integration as described by the author here. dotnet test from cli works fine.
  • NuGet publish configs were left untouched. It would be nice to port them to dotnet pack sometime in future. That way there will be no need to bundle NuGet.exe

@bannerflow-hassaan bannerflow-hassaan mentioned this pull request Dec 3, 2016
Closed
@JohannesHoppe
Copy link
Member

👍

Excellent work, I'm going to create a new repository / nuget package for it!
I will find some time during the weekend (or earlier :-)).

@ash23
Copy link

ash23 commented Dec 16, 2016

I am in urgent need of this PR to be merged and released.
Any update on when you think this will be done :) ?

Btw, this library is totally awesome, great work!

@JohannesHoppe
Copy link
Member

JohannesHoppe commented Dec 19, 2016 •
edited
Loading

Ok, i merged this.
I'm wondering if it would be possible, to target old and new .NET framework in one Nuget package:
https://docs.microsoft.com/en-us/dotnet/articles/core/tutorials/libraries#how-to-multitarget

Right now the project.json is all about NETStandard.
As I'm short in time, we would need to find somebody who makes this multitarget-ready.

@JohannesHoppe JohannesHoppe merged commit 3a11beb into Mongo2Go:master Dec 19, 2016
JohannesHoppe added a commit that referenced this pull request Dec 20, 2016
@JohannesHoppe
Mongo2Go 2.0.0-alpha1 with support for .NET Standard 1.6 only, which c…
75de4a6 
…loses #25

FYI @bannerflow-hassaan @ash23
@JohannesHoppe
Copy link
Member

Ok, gentlemen. Here it is:
https://www.nuget.org/packages/Mongo2Go/2.0.0-alpha1
This package has support for .NET Standard 1.6 only (no 4.6.x is in the package).

I struggled a bit with the folder structure. As far as I know, dotnet pack is not smart enough to include the tools folder, and nuget.exe was not aware of .NET Standard 1.6 (error Description: The folder 'netstandard1.6' under 'lib' is not recognized as a valid framework name or a supported culture identifier.)
I did it a little hack by referencing the files via wildcard: https://github.com/Mongo2Go/Mongo2Go/blob/master/Mongo2Go.nuspec#L36 - which resolves to lib\netstandard1.6\Mongo2Go.dll and friends.

@bannerflow-hassaan
@ash23
Could you please confirm that it works for you?

@bannerflow-hassaan
Copy link
Contributor Author

@JohannesHoppe Thanks a lot! .. let me test it this evening

@JohannesHoppe JohannesHoppe mentioned this pull request Dec 20, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bannerflow-hassaan @JohannesHoppe @ash23