Fix binary search path on Linux when NUGET_PACKAGES is specified #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: When specifying the NUGET_PACKAGES environment variable on Linux, the search pattern does not work because it then looks the following: * `$NUGET_PACKAGES/packages/Mongo2Go*/*/tools/mongodb-linux*/bin` * `$NUGET_PACKAGES/packages/mongo2go/*/*/tools/mongodb-linux*/bin` * `$NUGET_PACKAGES/mongo2go/*/*/tools/mongodb-linux*/bin` This is 1 `*` too many. Also fixed error message if no binaries are found to include all search patterns.
|
EDIT: Just found this issue #134 where the same solution is proposed, but there is no PR |
|
Author of #134 references a branch with the same solution here https://github.com/techgeek03/Mongo2Go/tree/bugfix/linux-paths Would love to see one of these solutions make it in. Mongo2Go is a fantastic project, but currently we are unable to use it in Azure DevOps, so testing is restricted to running it locally only. |
|
LGTM, let's see if it works! Many thanks! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When specifying the NUGET_PACKAGES environment variable on Linux, the search pattern does not work because it then looks the following:
$NUGET_PACKAGES/packages/Mongo2Go*/*/tools/mongodb-linux*/bin$NUGET_PACKAGES/packages/mongo2go/*/*/tools/mongodb-linux*/bin$NUGET_PACKAGES/mongo2go/*/*/tools/mongodb-linux*/binThis is 1
*too many.Also fixed error message if no binaries are found to include all search patterns.