throw exception if cluster not ready for transactions after singleNodeReplSetWaitTimeout
#103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow right away, don't wait to check if cluster is ready for transactions
…still not ready for transactions, throw exception
…ow also waiting for a server to be connected and data-bearing
|
LGTM! 👍 |
|
@zmira Thank you very much for your continued support, i will publish a new version in some minutes. 👍 Unfortunately this test is still broken on my Mac (but runs flawlessly on Windows). |
|
Sorry. Unfortunately, no access to a Mac. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logic only throws a timeout exception if the replica set is not ready after
singleNodeReplSetWaitTimeoutseconds.A check for the cluster's readiness for transactions was added but nothing is done when the timeout expires. This pull request handles that.
Also, since it looks like this new check takes longer than the default timeout of 5 seconds, I increased the default timeout from
5to10seconds.